test: the diff page mounts whole against a stubbed fetch - #76
Merged
Conversation
One render with every query answered canned: the diff and its changed line, the anchored finding, the general-comments surface and the toolbar all have to appear, and an empty working tree has to say so. jsdom lays nothing out, so the virtualizer gets a fixed 800px world through the offset sizes it actually reads. The stale pnpm-lock.yaml that sat in packages/ui goes — the monorepo's lockfile is npm's. Closes #48 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
…e dialect Offset accessors are spied, not redefined, so teardown restores jsdom's own getters. Unstubbed paths 404 with their name so a new surface must extend the fixture. The thread comes from the wire helpers, the mock honors the hook's ready contract, and the orphan fallback being empty pins that the thread really anchored. Bumped to 0.10.6 over merged develop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48.
diff-page.tsxorchestrates threads, live status, tours, presence and the diff, and nothing rendered it in a test — three wiring regressions in a month would each have failed a stubbed-fetch mount.diff-page-smoke.test.tsxmounts the whole page under a memory router (loader-provided ref/theme/view) and a query client, with one stubbedfetchanswering/api/info,/api/diff(a real diff throughparseDiff),/api/threads,/api/live/status,/api/toursand the viewer beacon. It asserts the changed file and its word-diffed line render, the anchored finding is visible, the general-comments surface and view-switch buttons exist — and that an empty diff says so.offsetWidth/offsetHeight(what@tanstack/virtual-coreactually reads) plus a rect mock; shiki is mocked to its pre-load null state, which the page renders plainly anyway.packages/ui/pnpm-lock.yaml— a stale pnpm lockfile committed long ago upstream in this npm monorepo — is removed.Version bump 0.10.4 → 0.10.5 per AGENTS.md (will re-bump over develop if #74 lands first).